-
Notifications
You must be signed in to change notification settings - Fork 7.7k
bluetooth: OpenDroneID sample application w/ GAP Broadcaster Role. #81559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluetooth: OpenDroneID sample application w/ GAP Broadcaster Role. #81559
Conversation
74e0d87
to
7c377fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't comment on the code (besides it's missing copyright info for the original author(s), which isn't great. Added another comment for the README to be expanded a bit more
/* SPDX-License-Identifier: Apache-2.0 | ||
* Copyright 2024 NXP | ||
* | ||
* Referred from https://github.com/opendroneid/transmitter-linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing the copyright entry for the original author.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #82034
Overview | ||
******** | ||
|
||
A simple application demonstrating ODID Message transmission using the GAP Broadcaster role. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit obscure for people (like myself) not familiar with opendroneID. Would be nice to add a bit more context as to what it is about. You may also add a link to opendroneID repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #82034
Hi @kartben, Thank you for the review. We don't need this PR to be reviewed. We created this draft PR to make sure all checks were being passed. Kindly ignore this for now. I will finalize my changes and request a review later. |
Adding sample app for demonstrating transmission of OpenDroneID. Signed-off-by: Mayank Mahajan <mayankmahajan.x@nxp.com>
7c377fd
to
3adf184
Compare
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Adding sample app for demonstrating transmission of OpenDroneID.